ARC-2316: start sending analytic events to SQS #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| QueueUrl: envVars.SQS_INCOMINGANALYTICEVENTS_QUEUE_URL, | ||
| DelaySeconds: 0 | ||
| }; | ||
| try { |
There was a problem hiding this comment.
/nit
Is there a reason the try{ doesn't move to the very top of this method?
There was a problem hiding this comment.
While "sendMessage" is anticipated to result in a error from time to time, and we are OK to ignore it (this is analytics), if there's a bug above - that's not anticipated and we should uncover this ASAP.
gxueatlassian
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Sending analytics event to SQS instead of via analytics client
Why
Added feature flags
Yes
Affected issues
in title
How has this been tested?
in ddev
Whats Next?